fix: repair failing tests across utility library#213
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide throws on division by zero - date-utils: formatRelative uses Math.round (fixes off-by-one at 36h) - string-utils: fix wordCount for consecutive spaces; implement truncate - task-manager: implement remove, update, and sortBy methods - validator: allow long TLDs in isEmail and ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the 5 source modules. All 60 tests now pass (
bun test), with none of the 44 originally-passing tests broken.Changes
src/calculator.ts—dividenow throwsError("Division by zero")instead of returningInfinity.src/date-utils.ts—formatRelativeusesMath.roundinstead ofMath.floor, fixing the off-by-one (36h → "2 days ago").src/string-utils.ts—wordCountnow handles multiple consecutive spaces;truncateimplemented for within-limit, word-boundary, ellipsis-budget, and short-string cases.src/task-manager.ts— implementedremove,update(title/priority, returns false for unknown id), andsortBy(priority high→medium→low, createdAt oldest-first).src/validator.ts—isEmailallows long TLDs;isUrlaccepts URLs with ports.Verification
bun test: 60 pass / 0 failNotes
isEmail/isUrlremain intentionally lightweight permissive validators, not full RFC parsers.Constraints honoured